[frontend] Disabled workflows can not be activated on entities (#14800)#14820
Merged
SarahBocognano merged 1 commit intomasterfrom Mar 6, 2026
Merged
[frontend] Disabled workflows can not be activated on entities (#14800)#14820SarahBocognano merged 1 commit intomasterfrom
SarahBocognano merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14820 +/- ##
=======================================
Coverage 32.35% 32.35%
=======================================
Files 3111 3111
Lines 211872 211872
Branches 38395 38396 +1
=======================================
Hits 68557 68557
Misses 143315 143315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Archidoit
approved these changes
Mar 6, 2026
JeremyCloarec
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The problem that occurs here is that to be allowed to manipulate workflow we set the attribute " workflow_configuration " at true during the initialization of the entity settings.
BUT, we are looking at the attribute "workflowEnabled" (which is a boolean telling us if there is status created on this entity or not) to allow the add/edit of the workflow.
This was a case of egg and chicken here, as the workflowEnabled could never be at true if we are not capable of creating a status in the first place...
My solution here is to allow the edition even if there is no status to allow the user to use workflow if the attribute worklow_configuration is set at true.
An other solution is to maybe look at the workflow_configuration in the backend (isGlobalWorkflowEnabled function)to allow workflow, instead of looking at if status exists.
Related issues